Tabs are sometimes not resizing

[SeaDve]

When I closed a tab, there are times where the tabs will not have an equal length. For example, there are 4 tabs, I closed a tab so there will be 3 left, they are supposed to take 33.33% of the area of the tab bar but instead it is 25%, 25%, and 50%.

[rafaelmardojai]

I have seen that bug before, but probably is related to the Firefox tabs JS logic, so I don't think we can do much.

Usually I have many tabs open, so I don't see it often.

[nickavem]

I can reproduce this locally as well: https://youtu.be/K6g6IDn8oFY

[lunaneff]

@nickavem pretty sure that's an intentional firefox feature, so that you can close many tabs without having to move your mouse every time (since the close button stays in the same place)

[danielwolbach]

@nickavem this is actually the correct behavior.

However, it sometimes happens that tabs get resized incorrectly and at the wrong time.

Firefox.GNOME.Theme.Bug.mp4

[sajmon170]

Is there any progress on this issue? It's really annoying and weird because sometimes the tabs are working properly, but then they do this after some time:

@nickavem this is actually the correct behavior.

However, it sometimes happens that tabs get resized incorrectly and at the wrong time.
Firefox.GNOME.Theme.Bug.mp4

[rafaelmardojai]

@sajmon170 after the tabs rework for libadwaita-1.2 it has been consistent working fine for me, could you test the branch? https://github.com/rafaelmardojai/firefox-gnome-theme/tree/libadwaita-1.2

[sajmon170]

@sajmon170 after the tabs rework for libadwaita-1.2 it has been consistent working fine for me, could you test the branch? https://github.com/rafaelmardojai/firefox-gnome-theme/tree/libadwaita-1.2

@rafaelmardojai I've been testing this branch and it seems to work most of the time, but has the same problem as before (it reappeared today):

Also, the tab closing feels a bit clunky - when you close a tab the one on its left tries to resize itself for a while, then jumps back to its previous (proper) size because the mouse cursor is still on the tab bar.

[sajmon170]

@rafaelmardojai I found that the incorrect tab behavior gets triggered by enabling and pausing audio playback.

Steps to reproduce:

1. Open a bunch of tabs
2. Open a random YouTube video
3. Pause it after it started playing sound
4. Try to close tabs other than the YouTube one.

Steps 1 and 2 can be reversed. Step 3 seems to be necessary.
This triggers the problem in both normal and private browsing mode. Maybe it has something to do with the "speaker" icon appearing on tabs playing sound?

[Scotty-Trees]

I'm on v115 of Firefox and your theme and I am still seeing this issue pop up, of having one tab size be off compared to all the others when closing tabs and it can still be triggered by playing/pausing audio playback, like the previous users have mentioned.

Any progress on this in 2023? Please let me know if there's any additional information you may need, thank you.

[rafaelmardojai]

I'm on v115 of Firefox and your theme and I am still seeing this issue pop up, of having one tab size be off compared to all the others when closing tabs and it can still be triggered by playing/pausing audio playback, like the previous users have mentioned.

Any progress on this in 2023? Please let me know if there's any additional information you may need, thank you.

No progress for now. I will try to revisit the bug these days. But it's a problem caused by the full width tabs code, so enabling gnomeTheme.normalWidthTabs might be a workaround.

[Scotty-Trees]

Thanks for the reply Rafael. I'll give the gnomeTheme.normalWidthTabs workaround a try in the meantime and see how that goes. If and when you do revisit the bug, feel free to ping me if you need any extra eyes testing since I can trigger the bug currently pretty easily.