Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve theme on small window #133

Open
gigglylo opened this issue May 3, 2020 · 2 comments
Open

Improve theme on small window #133

gigglylo opened this issue May 3, 2020 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@gigglylo
Copy link

gigglylo commented May 3, 2020

firstly, thanks for this awesome theme, it looks good on my desktop.

secondly, i want to open a small issue on this theme.
as the tittle explains, the close button is overlapping with other button next to it. this happens when i resize the firefox window to the smallest size.

Screenshot from 2020-05-03 22-02-24

i played around with placement of the button on Tweaks app, it seems like if we put the close button on the right, it doesn't overlap (but other buttons are hidden)

@rafaelmardojai
Copy link
Owner

Yeah, i have noticed this too.

As you can see in the screenshot below, comparing default vs themed Firefox, we have a space problem.

This problem is mainly caused by Adwaita big margins/paddings and the windows buttons merged in the navbar. For example the thing is worse for someone with the three buttons enabled:

A perfect solution would be what was proposed in #131, but it's an impossible task to do with just CSS.

So I'm open to suggestions on what to do to make this theme friendlier to small windows.

@rafaelmardojai rafaelmardojai added bug Something isn't working help wanted Extra attention is needed labels May 3, 2020
@rafaelmardojai rafaelmardojai changed the title Close button overlaps other button on small window Improve theme on small window May 3, 2020
@rafaelmardojai
Copy link
Owner

Hey @mgueji, feel free to point there anything that can help us to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants