Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing candidates when using separators #33

Open
luminouw opened this issue Dec 11, 2024 · 0 comments
Open

Missing candidates when using separators #33

luminouw opened this issue Dec 11, 2024 · 0 comments

Comments

@luminouw
Copy link

luminouw commented Dec 11, 2024

Hello there,

When combining n words, the separators aren't used properly to go in between and some candidates are missing from the generated output.

Example :

With extra_combinations set to false, the following command returns 15 results including the abc string

# With extra_combinations set to false
bopscrk -m 1 -M 20 -n 3 -w a,b,c
[...]
a
b
c
ab
ac
ba
bc
ca
cb
abc
acb
bac
bca
cab
cba

Same command but with extra_combinations set to true and separators_chars=_ only to illustrate my issue, I get the following result with 39 words generated

a
b
c
ab
ac
ba
bc
ca
cb
abc
acb
bac
bca
cab
cba
a_
_a
b_
_b
c_
_c
b_a
ab_
_ba
a_b
c_a
ac_
_ca
a_c
ba_
_ab
c_b
bc_
_cb
b_c
ca_
_ac
cb_
_bc

Since the upper limit of number of words used for combinations (-n 3) and min/max length isn't an issue, I would expect to see words such as a_b_c in the generated list as the _ is used as a separator and as such would be used whenever n words are combined together.

Is this an expected behaviour or am I missing something ?

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant