Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Session docstring for verify attribute should note that it supports a string value. #6859

Open
muscovite opened this issue Dec 16, 2024 · 1 comment · May be fixed by #6865
Open

Comments

@muscovite
Copy link

Session docstring for verify attribute should note that it supports a string value.

Actual Result

Currently, the Session docstring notes that its verify attribute only supports a bool.

However, session.request supports a string for its verify arg: https://github.com/psf/requests/blob/main/src/requests/sessions.py#L550

and when a verify arg isn't passed to session.request, then session.verify is used instead:

https://github.com/psf/requests/blob/main/src/requests/sessions.py#L776
https://github.com/psf/requests/blob/main/src/requests/sessions.py#L70

Reproduction Steps

N/A

System Information

N/A

@muscovite muscovite changed the title Docstring: Documentation: Session docstring for verify attribute should note that it supports a string value. Dec 16, 2024
@M0d3v1
Copy link

M0d3v1 commented Jan 1, 2025

I've submitted a PR (#6865) to address this issue. Please let me know if there are additional changes required. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants