Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace(?) deprecated installation instructions in "Instrumenting a Go application for Prometheus" docs #2556

Open
atimeofday opened this issue Dec 12, 2024 · 2 comments · May be fixed by #2563
Open

Replace(?) deprecated installation instructions in "Instrumenting a Go application for Prometheus" docs #2556

atimeofday opened this issue Dec 12, 2024 · 2 comments · May be fixed by #2563
Assignees
@lhajouji
Labels
good first issue For people who want to get a first start. help-wanted

Comments

@atimeofday
Copy link

Hello,

As a new user of both Go and Prometheus, I ran into some issues and tentatively believe the instructions for installing the prometheus/client_golang libraries are outdated as of Go 1.17 in... August 2021. It appears go get was deprecated outside of Go Modules, and requires the creation of a Go Module first. Please let me know if this impression is incorrect, or if a small PR to adjust the instructions might be welcome.

Issue location: https://github.com/prometheus/docs/blob/main/content/docs/guides/go-application.md#installation
Issue contents:

go get github.com/prometheus/client_golang/prometheus
go get github.com/prometheus/client_golang/prometheus/promauto
go get github.com/prometheus/client_golang/prometheus/promhttp

Potential solution: preface go get instructions with go mod init <module_name> and a link to Go Module documentation
@beorn7
Copy link
Member

beorn7 commented Dec 17, 2024

I guess you are right, these are outdated instruction to get Go packages. A PR fixing this would be very welcome.

@beorn7 beorn7 added good first issue For people who want to get a first start. help-wanted labels Dec 17, 2024
@lhajouji
Copy link

Hello @beorn7,

I would gladly work on this.
Would you please assign it to me ?

Thanks !

@lhajouji lhajouji linked a pull request Dec 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lhajouji lhajouji

Labels
good first issue For people who want to get a first start. help-wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixing outdated instruction to get Go packages lhajouji/prometheus-docs
3 participants
@beorn7 @lhajouji @atimeofday