Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request] add support for host header rewrite #135

Open
awx-fuyuanchu opened this issue Feb 7, 2023 · 0 comments
Open

[feature request] add support for host header rewrite #135

awx-fuyuanchu opened this issue Feb 7, 2023 · 0 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@awx-fuyuanchu
Copy link

Traffic flow:

client  --> proxy.local.example.com[prom-label-proxy] ---> central.example.com[upstream]

We are using an ingress hostname as the upstream of a prom-label-proxy. The ingress relies on the host header to route the traffic.

But currently, the proxy doesn't rewrite the host header. As a result, prom-label-proxy will send requests to the upstream with the host header proxy.local.example.com and it'll always get a 404 error since the ingress couldn't find a proper route for this hostname.

So we are here to request a feature flag that could rewrite the host header while proxy requests.
@simonpasquier simonpasquier added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 12, 2023
graemechristie added a commit to graemechristie/prom-label-proxy that referenced this issue Jul 14, 2023
@graemechristie
Added command line option to set arbitrary headers on upstream query …
1b520e4 
…to prometheus

Added option to set host header on upstream query to prometheus - addresses prometheus-community#135
@graemechristie graemechristie mentioned this issue Jul 14, 2023
Open
graemechristie added a commit to graemechristie/prom-label-proxy that referenced this issue Jul 14, 2023
@graemechristie
Added command line option to set arbitrary headers on upstream query …
88275aa 
…to prometheus

Added option to set host header on upstream query to prometheus - addresses prometheus-community#135

Signed-off-by: Graeme Christie <[email protected]>
graemechristie added a commit to graemechristie/prom-label-proxy that referenced this issue Jul 14, 2023
@graemechristie
Added command line option to set arbitrary headers on upstream query …
2b26646 
…to prometheus

Added option to set host header on upstream query to prometheus - addresses prometheus-community#135

Signed-off-by: Graeme Christie <[email protected]>
graemechristie added a commit to graemechristie/prom-label-proxy that referenced this issue Nov 1, 2023
@graemechristie
Added command line option to set arbitrary headers on upstream query …
de75e14 
…to prometheus

Added option to set host header on upstream query to prometheus - addresses prometheus-community#135

Signed-off-by: Graeme Christie <[email protected]>
graemechristie added a commit to graemechristie/prom-label-proxy that referenced this issue Nov 1, 2023
@graemechristie
Added command line option to set arbitrary headers on upstream query …
2ab2ad7 
…to prometheus

Added option to set host header on upstream query to prometheus - addresses prometheus-community#135

Signed-off-by: Graeme Christie <[email protected]>
graemechristie added a commit to graemechristie/prom-label-proxy that referenced this issue Nov 1, 2023
@graemechristie
Added command line option to set arbitrary headers on upstream query …
3c0ae3f 
…to prometheus

Added option to set host header on upstream query to prometheus - addresses prometheus-community#135

Signed-off-by: Graeme Christie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonpasquier @awx-fuyuanchu