Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POST request failure when connected with a database having hyphen in the db name #369

Open
sarath16933 opened this issue Jul 14, 2020 · 5 comments · May be fixed by prest/adapters#54
Open

POST request failure when connected with a database having hyphen in the db name #369

sarath16933 opened this issue Jul 14, 2020 · 5 comments · May be fixed by prest/adapters#54
Labels
bug product/api-server REST API Server
Milestone
v1.2.0

Comments

@sarath16933
Copy link

{
"error": "unable to find table name"
}
I'm getting this response when making POST request to a db having hyphen in the db name. eg db name: "my-db".
GET, PUT, PATCH and DELETE are working fine.
@sarath16933
Copy link
Author

If "insertTableNameQuotesRegex" is updated, it should work.
Currently its not accepting db name or table name with hyphen
(?i)INTO\s+([\w|\.|"]*\.)*"(\w+)"\s*\(

@tiaguinho
Copy link
Member

Hi @sarath16933 thanks for reporting this issue.
Since you have found how to fix the bug, you are very welcome to send a PR to fix this.
What do you think? Can you do that?

Thank you.

@sarath16933
Copy link
Author

Thanks @tiaguinho. I shall raise a PR for the fix.

@sarath16933 sarath16933 linked a pull request Jul 15, 2020 that will close this issue
Open
@avelino avelino added the bug label Jul 23, 2020
@saqwel
Copy link

saqwel commented Sep 21, 2020

When will be this issue fixed?

@avelino
Copy link
Member

avelino commented Sep 21, 2020 •
edited by arxdsilva
Loading

When will be this issue fixed?

@saqwel unfortunately no, correction was sent, but we need a test before merging

@sarath16933 sarath16933 mentioned this issue Oct 5, 2020
Closed
@avelino avelino added the product/api-server REST API Server label Oct 5, 2020
@arxdsilva arxdsilva added this to the v1.2.0 milestone Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug product/api-server REST API Server
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

Fix insertTableNameQuotesRegex to support hyphen in dbname sarath16933/adapters
5 participants
@avelino @tiaguinho @arxdsilva @saqwel @sarath16933