Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orders API: Use get_unprefixed_state for state output to strip country prefix #4598

Open
birkjernstrom opened this issue Dec 4, 2024 · 0 comments
Labels
dx Efforts to enhance developer experience for creators enhancement Enhancement of existing features and services

Comments

@birkjernstrom
Copy link
Member

Stripe Tax uses ISO 3166-2 with subdivisions to perform a lookup on tax rates, e.g country-state, which makes sense. On checkout we therefore store the state in this format too for tax calculations.

However, customers expect a separation. Getting country from orders.billing_address.country and state from orders.billing_address.state (clean from country codes).

So our output of the schema should use get_unprefixed_state to strip the country code from the state output in our API.

@birkjernstrom birkjernstrom added dx Efforts to enhance developer experience for creators enhancement Enhancement of existing features and services labels Dec 4, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Backlog Dec 4, 2024
@birkjernstrom birkjernstrom moved this from Backlog to Upcoming in Backlog Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Efforts to enhance developer experience for creators enhancement Enhancement of existing features and services
Projects
Status: Upcoming
Status: No status
Development

No branches or pull requests

1 participant