-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HEEx doesn't raise No space between attributes error #3528
Comments
Although not ambiguous here, I understand why HTML does it. We could error but perhaps it makes more sense to warn, given the formatter will automatically fix it for you anyway, and that would not be possible if erroring. |
Now that LV is 1.0 I agree that this should not error. Considering it compiles anyway I didn't know if it was worth pursuing or not but figured I'd bring attention to it. |
And Floki parses this syntax just fine without warning, which means that Mochi parses just fine. I think I'll close this as a non-issue. I will have to account for this in LVN's template parser as we are erroring on it. |
Let's keep it open because I think warning is better. We don't want to have someone thinking this is fine and then emitting some hand written HTML somehow with this bug :) |
FWIW, browsers parse it as multiple attributes too, but they are also historically known to be very lenient. |
yeah I sent it through the W3C validator which will be less forgiving |
This works just fine:
It will render as :
but the original template is invalid and shouldn't compile.
The text was updated successfully, but these errors were encountered: