Functions with datetime arguments

[adieyal]

Thanks for an excellent library.

I was wondering what the best approach for defining tools whose functions have datetime arguments. From my reading of the code, it seems that you need to create a custom Function since get_json_schema doesn't handle dates. e.g.

class SalesFunction(Function):
    ...
    parameters: Dict[str, Any] = {
        "type": "object",
        "properties": {
            "start_date": {
                "type": "string",
                "format": "date-time",
                "description": ...
            },
            "end_date": {
                "type": "string",
                "format": "date-time",
                "description": ...
            }
        }
    }

    entrypoint: Callable[[str, str], str] = ...

perhaps an alternative would be to customise get_json_schema and then override from_callable to use the new function?

phidata/phi/tools/function.py

Lines 27 to 44 in a598b58

	def from_callable(cls, c: Callable) -> "Function":
	from inspect import getdoc
	from phi.utils.json_schema import get_json_schema
	parameters = {"type": "object", "properties": {}}
	try:
	type_hints = get_type_hints(c)
	parameters = get_json_schema(type_hints)
	# logger.debug(f"Type hints for {c.__name__}: {type_hints}")
	except Exception as e:
	logger.warning(f"Could not parse args for {c.__name__}: {e}")
	return cls(
	name=c.__name__,
	description=getdoc(c),
	parameters=parameters,
	entrypoint=validate_call(c),
	)

[ashpreetbedi]

This is great callout @adieyal. You're right we'll have to customize get_json_schema and the get_json_type_for_py_type function to first let the LLM call the function with datetime arguments -- which the LLM will send back as str

https://github.com/phidatahq/phidata/blob/main/phi/utils/json_schema.py#L6-L22

Then we'll also have to update the execute function to handle incoming datetimes because they'll come as strings from the LLM, and we'll have to parse them into datetime objects

https://github.com/phidatahq/phidata/blob/main/phi/tools/function.py#L74-L102

I can work on this over the weekend