Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remove() and isRemoved in HTMLRewriterTypes.Doctype interface #16020

Closed
metent opened this issue Dec 27, 2024 · 0 comments · Fixed by #16031
Closed

Add remove() and isRemoved in HTMLRewriterTypes.Doctype interface #16020

metent opened this issue Dec 27, 2024 · 0 comments · Fixed by #16031
Labels
enhancement New feature or request HTMLRewriter cloudflare workers API

Comments

@metent
Copy link

metent commented Dec 27, 2024

What is the problem this feature would solve?

Currently, the argument for the doctype handler in HTMLRewriterDocumentContentHandlers is missing remove() method and removed property. These APIs were added in lol-html v0.3.3. I assume they were not created as very few people use these APIs but it has niche use cases (like extracting a single node).

What is the feature you are proposing to solve the problem?

Create Zig bindings to lol_html_doctype_remove and lol_html_doctype_is_removed functions and JavaScript bindings to those Zig APIs. Having type declarations for these APIs will also be very useful.

What alternatives have you considered?

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request HTMLRewriter cloudflare workers API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add remove() and isRemoved in HTMLRewriterTypes.Doctype interface Devanand-Sharma/bun
2 participants
@DonIsaac @metent