[Good First Issue] [NNCF] Make NNCF common pruning code pass mypy checks

[vshampor]

This is exactly like #2495 (see the description and tasks there), but the target code path for this one is nncf/common/pruning instead of nncf/common/graph.

[Lymah123]

Hi @vshampor , can I work on this?

[rkazants]

Hi @Lymah123, the task is assigned to you.

Best regards,
Roman

[p-wysocki]

Hello @Lymah123, are you still working on that issue?

[RitikaxShakya]

.take

[github-actions]

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

[p-wysocki]

Hello @RitikaxShakya, are you still working on that issue?

[RitikaxShakya]

yes, i am looking into the issue

[p-wysocki]

Please let us know if there are any updates.

[RitikaxShakya]

Hello! Sorry for late reply. I've installed mypy and now I'll create/update the mypy.ini configuration file in the project's root directory to tailor Mypy's settings to our specific needs.

[RitikaxShakya]

Hello! This is just an update:
so i found these many errors:

And now I am on my way solving these so reached this much :

[RitikaxShakya]

Hello! @vshampor @p-wysocki I would like to know how I ensure or test that my changes in the code are not changing logic. I am using pytest but is there anything else, please let me know.

Thank you!

[vshampor]

Greetings, @RitikaxShakya! Indeed, you should orient yourself on the pytest runs. These are available as corresponding test-* Makefile targets in the repo root, and the same targets are being run as PR precommit checks.

[RitikaxShakya]

@p-wysocki Hello! i raised a PR for this issue. Please take a look whenever possible. Thank you!

[p-wysocki]

Thank you for your contribution! cc @vshampor