Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test coverage for _normalize_result #810

Open
kalikiana opened this issue Feb 1, 2024 · 2 comments
Open

Add unit test coverage for _normalize_result #810

kalikiana opened this issue Feb 1, 2024 · 2 comments
Assignees
@RaheelaTabassum
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@kalikiana
Copy link
Member

_normalize_result / update_result is lacking unit test coverage. This came up during code review. See openSUSE/qem-bot#154 (comment)

Relevant code:

qem-dashboard/lib/Dashboard/Model/Jobs.pm

Line 86 in 2d5dfec

my $normalized = _normalize_result($result);

@kalikiana kalikiana mentioned this issue Feb 1, 2024
Open
@okurz okurz added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels May 10, 2024
@RaheelaTabassum
Copy link

please assign this issue to me @okurz

@okurz
Copy link
Member

okurz commented Nov 11, 2024

We are happy to receive pull requests for all contributors. No need to assign you to the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RaheelaTabassum RaheelaTabassum

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kalikiana @okurz @RaheelaTabassum