Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t use hardcoded color values #363

Open
ariasuni opened this issue Mar 5, 2018 · 6 comments · May be fixed by #786
Open

Don’t use hardcoded color values #363

ariasuni opened this issue Mar 5, 2018 · 6 comments · May be fixed by #786

Comments

@ariasuni
Copy link
Collaborator

ariasuni commented Mar 5, 2018

Images file names are illegible on my computer; but I can’t change their colors because it’s hardcoded. There’s a few of them:

https://github.com/ogham/exa/search?utf8=%E2%9C%93&q=Fixed&type=

Would you accept a pull request that change those fixed values? For example, the purple color used for music, Fixed(92), would become ansi_term::Colour::Purple.
@ariasuni ariasuni mentioned this issue Mar 30, 2018
Closed
@weilbith
Copy link

I''ve similar problems. I love this tool, but folders (which are quite common I guess), aren't well visible in my colour-scheme. I guess having these colors hard-coded is faster, but I would trade this millisecond for the possibility to adjust them.

@ariasuni do you have already an adjusted implementation in a fork I could use? #370 doesn't so, am I correct?

@ariasuni
Copy link
Collaborator Author

You can build my branch use-only-named-colors on my fork of the repository, since exa has only received a few commits and no release in the meantime. Any feedback is appreciated.

@rugk
Copy link

rugk commented Oct 15, 2018 •
edited
Loading

Also related to #425

@rugk rugk mentioned this issue Oct 15, 2018
Closed
@novoid
Copy link

novoid commented Jan 27, 2019

I do have a similar issue with not being able to read executable items using exa v0.8.0 and a dark theme: https://ibb.co/SwGDTKD

@rugk
Copy link

rugk commented Jan 20, 2020 •
edited
Loading

Fixed by #607 (?)

@ariasuni
Copy link
Collaborator Author

It’s not fixed for file types.

Would you accept a PR taking the same approach than #607 for file types (and also punctuation), @ogham?

This would solve the issue for me, and we can still argue about the default colors later.

@ariasuni ariasuni mentioned this issue Mar 19, 2020
Open
@ariasuni ariasuni linked a pull request Jan 6, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@novoid @ariasuni @rugk @weilbith