Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2 Gem does not build with the newest Jazzy #813

Open
jhanca-robotecai opened this issue Dec 31, 2024 · 2 comments
Open

ROS2 Gem does not build with the newest Jazzy #813

jhanca-robotecai opened this issue Dec 31, 2024 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/blocker Highest priority. Must be actively worked on right now as it is blocking other work. sig/simulation Categorizes an issue or PR as relevant to SIG Simulation

Comments

@jhanca-robotecai
Copy link
Contributor

jhanca-robotecai commented Dec 31, 2024

Describe the bug
ROS 2 Gem does not build on Ubuntu 24.04 with the newest ROS 2 Jazzy

Steps to reproduce

  1. Update ROS 2 Jazzy to the newest version
  2. Pull the code
  3. Build

Expected behavior
The code builds

Actual behavior

In file included from /home/jhanca/devroot/2409/o3de-extras/Gems/ROS2/Code/Include/ROS2/Utilities/Controllers/PidConfiguration.h:11:
In file included from /opt/ros/jazzy/include/control_toolbox/control_toolbox/pid.hpp:41:
/opt/ros/jazzy/include/realtime_tools/realtime_tools/realtime_buffer.h:25:2: error: "This header include is deprecated. Please update your code to use 'realtime_buffer.hpp' header." //NOLINT [-Werror,-W#warnings]
   25 | #warning \
      |  ^
1 error generated.

Found in Branch
main (2409.1), but it will be the same in development

Desktop/Device (please complete the following information):

  • Device: Laptop
  • OS: Ubuntu
  • Version 24.04.1. LTS

Additional context
Update that cause the issue:

Preparing to unpack .../151-ros-jazzy-control-toolbox_3.4.0-1noble.20241228.012401_amd64.deb ...
Unpacking ros-jazzy-control-toolbox (3.4.0-1noble.20241228.012401) over (3.3.0-1noble.20241118.192236)
@jhanca-robotecai jhanca-robotecai added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. priority/blocker Highest priority. Must be actively worked on right now as it is blocking other work. sig/simulation Categorizes an issue or PR as relevant to SIG Simulation and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 31, 2024
@jhanca-robotecai
Copy link
Contributor Author

The issue was auto-detected two weeks ago and raised on the respective repository: ros-controls/control_toolbox#248

@adamdbrw
Copy link
Contributor

adamdbrw commented Jan 2, 2025

This is the second time the control_toolbox package causes issues. The issue you point to has been closed as completed, could you check if this still a problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/blocker Highest priority. Must be actively worked on right now as it is blocking other work. sig/simulation Categorizes an issue or PR as relevant to SIG Simulation
Projects
None yet
Development

No branches or pull requests

2 participants