-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider moving away from the "title" attributes due to conflict with tooltips #530
Comments
Hey! Yeah, you're absolutely right, using |
Thanks for the quick reply. I don't think it'll be a breaking change -- what's needed is a change in the underlying implementation that forwards the react-share/src/ShareButton.tsx Lines 83 to 86 in 1d6cd0f
I don't think the problem is only with the MUI Tooltip. As the MDN link suggests, using For me, the best workaround is probably some patch that fixes the issue 😄 |
Ahha, I see it now! I misunderstood you at first. Makes sense. Please check #531 if you think it would fix the issue for you! |
This doesn't solve the MUI warning but I saw the Thanks for the fix! |
Looks like, MUI Tooltip assumes that the component's props are spread to the underlying HTML element. It looks like the fix has to rename Having said these, #531 is also a useful fix probably outside the MUI context. |
To summarize, the whole story is:
|
MDN doc says:
However, react-share uses
title
for totally unrelated purposes IIUC. This makes it somewhat hard to put a tooltip with a different text on a share button in some cases.My Particular Example
If using with MUI Tooltip, I would get the following warning:
Code:
I see this warning legitimate due to the cited MDN doc above.
The text was updated successfully, but these errors were encountered: