Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Load focus trap extension in markdown content editor #6823

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

juliusknorr
Copy link
Member

Fix nextcloud/deck#6550

We should make sure to also load the focus trap plugin when using the markdown content editor e.g. in deck as otherwise using the tab key will just focus on the next element instead of triggering editor functionality first.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.59%. Comparing base (6702ab9) to head (d15759b).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Editor/MarkdownContentEditor.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6823      +/-   ##
==========================================
+ Coverage   46.56%   46.59%   +0.02%     
==========================================
  Files         748      733      -15     
  Lines       34307    34290      -17     
  Branches     1242     1227      -15     
==========================================
  Hits        15976    15976              
+ Misses      17709    17707       -2     
+ Partials      622      607      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Focus on text editor is lost when trying to create multi-level nested list
1 participant