Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Shared Folder with Custom Permissions Displays as "View Only" #49941

Open
4 tasks done
kesselb opened this issue Dec 20, 2024 · 4 comments
Open
4 tasks done

[Bug]: Shared Folder with Custom Permissions Displays as "View Only" #49941

kesselb opened this issue Dec 20, 2024 · 4 comments
Assignees
Labels
1. to develop Accepted and waiting to be taken care of 30-feedback bug regression

Comments

@kesselb
Copy link
Contributor

kesselb commented Dec 20, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

When sharing a folder with custom permissions (e.g., "Read & Share"), the share functions correctly, but the list of shares incorrectly displays the permissions as "View Only," causing confusion for users.

Steps to reproduce

  1. Share a folder with another user using custom permissions ("Read & Share").
  2. The list of shares for the share owner shows "View only"

The share itself seems to work, only the permissions are shown wrong.

Screencast.From.2024-12-20.14-27-39.webm

Expected behavior

The list should display "custom permissions

Nextcloud Server version

30

@kesselb kesselb added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Dec 20, 2024
@diegmero

This comment has been minimized.

@sorbaugh

This comment has been minimized.

@skjnldsv
Copy link
Member

Same goes for the opposite.
If you create a view-only, then open the menu and click "customize", it will be shown as "custom permissions"

Image

This is because we have the default sharing including share to allow users to add link shares to their own account with this UI
Image

if ($this->shareManager->outgoingServer2ServerSharesAllowed()) {
$permissions |= Constants::PERMISSION_SHARE;
}

hasCustomPermissions() {
const bundledPermissions = [
BUNDLED_PERMISSIONS.ALL,
BUNDLED_PERMISSIONS.READ_ONLY,
BUNDLED_PERMISSIONS.FILE_DROP,
]
return !bundledPermissions.includes(this.share.permissions)
},

@skjnldsv
Copy link
Member

@nfebe this is a customer issue. We need to find a fix for the next release early January

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of 30-feedback bug regression
Projects
None yet
Development

No branches or pull requests

6 participants