[Bug]: Sharing records are not deleted after a file/folder has been permanently deleted

[luka-nextcloud]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

Right now, deleting a file/folder does not delete its corresponding sharing records. After a file/folder has been deleted, sharing records should also be deleted.

Steps to reproduce

1. Create a file/folder
2. Share the created file/folder
3. Permanently delete that file/folder
4. Check table oc_share
   Expect: It's sharing records deleted
   Actual: It's sharing records still exist

Expected behavior

Sharing records should also be removed from the oc_share table.

Nextcloud Server version

28

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

List of activated Apps

Nextcloud Signing status

Nextcloud Logs

Additional info

Reproducible on 28, 29, 30, master

[nickvergessen]

This would mean if you accidentally delete a file and restore it from the trashbin, all shares are still destructed.

If we rephrase

After a file/folder has been deleted, sharing records should also be deleted.

to

After a file/folder has been deleted and removed from the trashbin, sharing records should also be deleted.

it would work. But I somewhat expect that this is already the case.

[luka-nextcloud]

I agree that we should only remove sharing records after a file/folder has been permanently deleted. Now the sharing records still exist even after the permanent delete.

[nickvergessen]

This daily running job should clear them:

server/apps/files_sharing/lib/DeleteOrphanedSharesJob.php

Line 23 in 3810770

class DeleteOrphanedSharesJob extends TimedJob {

[XueSheng-GIT]

Does this daily job work as expected? Two weeks ago I had an issue with moving a share and finally found out that it was becaus of an orphaned share. After running occ sharing:delete-orphan-shares the issue was resolved.
Because this was an old share, I question whether this daily job is enough.