Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: List of files uploaded to File Drop contains unlabeled icons #49923

Open
4 of 8 tasks
rosahaj opened this issue Dec 19, 2024 · 1 comment
Open
4 of 8 tasks

[Bug]: List of files uploaded to File Drop contains unlabeled icons #49923

rosahaj opened this issue Dec 19, 2024 · 1 comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 30-feedback bug

Comments

@rosahaj
Copy link

rosahaj commented Dec 19, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

After uploading files to a File Drop, an icon indicating the file type is displayed next to the file name (e.g. a small PDF icon for PDF files). Because the icon is neither labeled nor hidden from accessibility APIs, it's described as an unlabeled image when using certain screen readers together with certain browsers (such as Google TalkBack + Google Chrome).

Relevant HTML snippet (after file upload):

<ul id="drop-uploaded-files">
  <li title="Example.pdf" data-name="Example.pdf">
    <img src="/apps/theming/img/core/filetypes/application-pdf.svg?v=1b3d5f7a"> Example.pdf
  </li>
</ul>

Since the file type is inferred based on the file extension alone and does not provide any new information not already contained in the filename, the icon is merely a visual aid. I believe the icon should therefore be hidden from accessibility APIs with aria-hidden="true".

Steps to reproduce

  1. Create new file request
  2. Upload a file to File Drop

Expected behavior

Image is ignored by accessibility APIs

Nextcloud Server version

30

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

List of activated Apps

Nextcloud Signing status

Nextcloud Logs

Additional info

No response

@rosahaj rosahaj added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Dec 19, 2024
@rosahaj
Copy link
Author

rosahaj commented Dec 23, 2024

I noticed that the icon displayed next to the uploaded files not only indicates the file type, but can also indicate that the upload of a specific file has failed. Rather than hiding the icon from the accessibility tree, it could be labeled in accordance with the file type (for successfully uploaded files) or with an "upload failed" label (for unsuccessfully uploaded files).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 30-feedback bug
Projects
None yet
Development

No branches or pull requests

2 participants