Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: versions 30.0.2 and earlier do not send an email notification when a file is uploaded or deleted, only if renamed #49133

Open
5 of 8 tasks
tigernero79 opened this issue Nov 7, 2024 · 51 comments · Fixed by #49688
Assignees
Milestone

Comments

@tigernero79
Copy link

⚠️ This issue respects the following points: ⚠️

Bug description

Hello developers.

After updating to version 30.0.2, file sharing via email doesn't work as it should, I think. No email is sent to the sharer unless you rename the file.

So, the person I try to share files with doesn't get notifications except when the file is renamed. Nothing in the logs.

Typically, email works.

Steps to reproduce

  1. upload files to a folder with active notifications
  2. wait for an email notification of successful upload to be sent
    3.no notification email is sent to the recipient
  3. however, if you modify the already existing file, the recipient receives notification of the renaming

Expected behavior

I expect that when I upload a file I will be notified via email

Nextcloud Server version

30

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.3

Web server

Apache (supported)

Database engine version

MySQL

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@tigernero79 tigernero79 added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Nov 7, 2024
@tigernero79 tigernero79 changed the title [Bug]: 30.0.2 and lower versions do not email when a file is uploaded or deleted but only if renamed [Bug]: versions 30.0.2 and earlier do not send an email notification when a file is uploaded or deleted, only if renamed Nov 7, 2024
@tigernero79
Copy link
Author

#48012 (comment)

@rx80

This comment has been minimized.

@tigernero79

This comment has been minimized.

@martink1979

This comment has been minimized.

@tigernero79

This comment has been minimized.

@RDequal

This comment has been minimized.

@5pr1nz

This comment has been minimized.

@dom6770

This comment has been minimized.

@tigernero79

This comment has been minimized.

@jfriedrichs85

This comment has been minimized.

@skjnldsv skjnldsv added 2. developing Work in progress and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Dec 6, 2024
@skjnldsv skjnldsv self-assigned this Dec 6, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Dec 6, 2024

Alright folks, sorry for the trouble and thanks for pinging again.
We're a bit overwhelmed here 🫠

Just to clarify, we're talking about this, correct? (don't respond, use reactions pls 👍 👎 )

  1. Create a mail share to someone
  2. That someone does receive a mail notification
  3. Have that someone send files to the folder you share
  4. You don't get notifications as you should 😢

@dom6770
Copy link

dom6770 commented Dec 6, 2024

We could observe this bug on any shared folder, regardless if it was shared by mail or shared to another nextcloud user.

@martink1979

This comment has been minimized.

@skjnldsv

This comment has been minimized.

@skjnldsv
Copy link
Member

skjnldsv commented Dec 6, 2024

I think I could find the issue!
I'm guessing everyone have that settings disabled?

Image

@LM-vb
Copy link

LM-vb commented Dec 6, 2024

Enabling these options solved it for me. Is this option new?

@skjnldsv
Copy link
Member

skjnldsv commented Dec 6, 2024

Since Nextcloud 30.
Mails was not enabled by default, which I guess we should.

@LM-vb
Copy link

LM-vb commented Dec 6, 2024

Neither push nor mail was enabled for me.

@skjnldsv
Copy link
Member

skjnldsv commented Dec 6, 2024

Fix in #49688

@tigernero79
Copy link
Author

the problem is that after uploading the same file if I rename it I get an email and it arrives right away. there is something wrong with the file upload or deletion notifications

@tigernero79
Copy link
Author

test email setup worked right away. the problem exists in my opinion.

@skjnldsv
Copy link
Member

skjnldsv commented Dec 6, 2024

It depends on your cron setup.
That behavior didn't change

@tigernero79
Copy link
Author

I have the cron set every 5 minutes and it always worked until release 29. really strange

Image

@tigernero79
Copy link
Author

in the basic settings section I checked use system email account and not the user one I'll try and update you

Image

@martink1979

This comment has been minimized.

@dom6770
Copy link

dom6770 commented Dec 9, 2024

Sorry, I fail to see how this fixes it.

The notifications are turned on, yet I still receive only a mail when the file is being renamed. I do not get a mail when I upload/delete a file or create a new folder.

All mail notifications for sharing are turned on at the user's account, which created the share, and notifications are set to be sent immediately. We use cron each 5 minutes. Before updating to version 30 everything worked correctly. Test Mail do also work. I see no errors in the logs.

@zeqret
Copy link

zeqret commented Dec 9, 2024

Sorry, I fail to see how this fixes it.

The notifications are turned on, yet I still receive only a mail when the file is being renamed. I do not get a mail when I upload/delete a file or create a new folder.

All mail notifications for sharing are turned on at the user's account, which created the share, and notifications are set to be sent immediately. We use cron each 5 minutes. Before updating to version 30 everything worked correctly. Test Mail do also work. I see no errors in the logs.

I have the exact same issue

@dom6770
Copy link

dom6770 commented Dec 13, 2024

Should I open a new issue, or is this getting reopened?

Thanks.

@5pr1nz
Copy link

5pr1nz commented Dec 13, 2024

I agree, this is not fixed. The same issue remains!

@tigernero79
Copy link
Author

yes unfortunately even with nextcloud 30.0.4 the problem remained

@skjnldsv skjnldsv reopened this Dec 13, 2024
@skjnldsv

This comment has been minimized.

@tigernero79
Copy link
Author

@skjnldsv

problem also encountered with version 30.0.4 is very simple, you upload a file having the notification alerts active but you do not receive any email indicating that the file has been uploaded so an administrator must continuously check the folder to know if a user has uploaded something. I hope I was clear. in version v.29.x.x the notifications of successful file upload were sent correctly.

@kluchoslaw
Copy link

Now I think in 30.0.4 is ok for me.
Just have a look at Administration Settings => Activity =>checkbox "Files have been uploaded to a folder shared by mail or by public link" It is new in 30.0.x version but not well announced.

@tigernero79
Copy link
Author

Image

as you can see i have enabled the voice, but when some user or myself upload a file this does not generate any information email. I do not receive any activity report email, with nextcloud 29.x it worked

@kluchoslaw
Copy link

I dont know if this is the case but can you check on new user? As it is written higher in Activity "Configure the default notification settings for new accounts. "

@zeqret
Copy link

zeqret commented Dec 17, 2024

I dont know if this is the case but can you check on new user? As it is written higher in Activity "Configure the default notification settings for new accounts. "

I use 30.0.4 and also tried a new account. Same issue. I receive mail notification that folder is shared, and mail if files are renamed but I do not get any mail if files are uploaded, even if the option is enabled

@tigernero79
Copy link
Author

Non so se è questo il caso, ma puoi controllare il nuovo utente? Come è scritto più in alto nell'Attività "Configura le impostazioni di notifica predefinite per i nuovi account".

Io uso 30.0.4 e ho anche provato un nuovo account. Stesso problema. Ricevo una notifica via e-mail che la cartella è condivisa e un'e-mail se i file vengono rinominati, ma non ricevo alcuna e-mail se i file vengono caricati, anche se l'opzione è abilitata

exactly, the notification only arrives if I rename the file once uploaded, or if I rename in general but no notification occurs if I upload the file

@LaSepp
Copy link

LaSepp commented Dec 17, 2024

We're facing the same issue.

To be clear: I don't know if it would work on a shared link or email with the mentioned option, but we are not doing this.
We share the folder to other users on the same nextcloud instance.

Uploads and deletes show up in the activity app but not in the notification mail.
Renames and moves do show up in both the activity app and the notificatition mail.

@hosse
Copy link

hosse commented Dec 20, 2024

We have had this problem since version 30.0.0 to 30.0.4.

Since there is no solution so far, I am using the following workaround:

.../www/nextcloud/lib/private/Share20/Share.php

#from line 590 see // and add line return true,

    public function getMailSend() {
            //changed by us
            //return $this->mailSend;
            return true;
    }

@kesselb kesselb changed the title [Bug]: versions 30.0.2 and earlier do not send an email notification when a file is uploaded or deleted, only if renamed [Bug]: no sharebyemail notification for user shares Dec 20, 2024
@kesselb kesselb added 1. to develop Accepted and waiting to be taken care of and removed 3. to review Waiting for reviews labels Dec 20, 2024
@kesselb
Copy link
Contributor

kesselb commented Dec 20, 2024

Hi everyone,

I’m sorry to hear that you’re encountering issues with the sharing functionality in Nextcloud 30. I’ve noticed that a lot of different topics are getting mixed up here, so I’d like to clarify things.

Image

I assume most of you are referring to the email mentioned above. This email is generated by a component called sharebyemail. Some of you have also shared your activity/notification configurations, but please note that those are unrelated to the issue. The emails you’re receiving when a file is modified or similar notifications are handled by the activity component.

In Nextcloud 29, this email was sent when sharing something either with external users (e.g., [email protected]) or with users on your own Nextcloud instance.

Both cases were broken in Nextcloud 30.0.0. The issue with external shares was fixed in Nextcloud 30.0.2 with the following PR: #48381. However, the bug affecting shares with users on your instance was overlooked.

The issue is already assigned, and we’re doing our best to address the situation as soon as possible.

I hope this clears things up! Let me know if you have any further questions or need more details.

@kesselb
Copy link
Contributor

kesselb commented Dec 21, 2024

Sorry, everyone—looks like I mixed things up 🙈.

I hope my explanation about activities and share notifications was still helpful for some of you.

If you are also missing the email notification for a new share, then please give a thumbs-up to this issue: #49954.

Thanks for your patience!

@kesselb kesselb changed the title [Bug]: no sharebyemail notification for user shares [Bug]: versions 30.0.2 and earlier do not send an email notification when a file is uploaded or deleted, only if renamed Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.