Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links at bottom of public share page on private instance goes to nextcloud.com #20253

Closed
estan opened this issue Apr 1, 2020 · 10 comments
Closed
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug

Comments

@estan
Copy link

estan commented Apr 1, 2020

Steps to reproduce

  1. Set up a private Nextcloud instance
  2. Create a shared file or folder link
  3. Visit the shared link

Expected behaviour

Either there should be no links at the bottom when the instance is private, or they should point to the private instance URL.

Actual behaviour

There are two links at the bottom of the page

These two links are confusing for people with whom you've shared your link, because they may click them, ending up on the public Nextcloud.

Server configuration

Operating system: Ubuntu 18.04

Web server: Apache 2.4.29

Database: PostgreSQL 10.10

PHP version: 7.2.24

Nextcloud version: 18.0.3

Updated from an older Nextcloud/ownCloud or fresh install: Updated

Where did you install Nextcloud from: Source

@estan estan added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Apr 1, 2020
@gary-kim
Copy link
Member

gary-kim commented Apr 1, 2020

You can add the following to your config.php to remove that.

'simpleSignUpLink.shown' => false,

BTW, these kinds of questions are probably more suitable for the forum rather than the issue tracker.

@estan
Copy link
Author

estan commented Apr 1, 2020

@gary-kim Thanks for the quick response. I must have missed that config option. Closing issue.

@estan estan closed this as completed Apr 1, 2020
@estan
Copy link
Author

estan commented Apr 1, 2020

Sorry, that option only removes the "Get your own free account" link, not the "Nextcloud – a safe home for all your data" link. Re-opening.

@estan estan reopened this Apr 1, 2020
@gary-kim
Copy link
Member

gary-kim commented Apr 1, 2020

That part is from theming. You're welcome to to change that around in theming. This is my instance, for example:
image

The link that it points to is also configured from theming.

Also, again, more suitable for the forum rather than the issue tracker.

@estan
Copy link
Author

estan commented Apr 1, 2020

Okay, sorry. Even if it is part of theming, I thought it an issue that the default theme is showing a link to nextcloud.com even on a private instance. But if it's not considered an issue by Nextcloud team I'll close this issue.

@gary-kim
Copy link
Member

gary-kim commented Apr 1, 2020

All instances are private so...

Anyways, personally, I would not consider this a bug

@estan
Copy link
Author

estan commented Apr 1, 2020

Alright, after thinking a bit about it, I think I agree. Linking to nextcloud.com is a good default. So closing issue. Someone can reopen if they disagree.

Potentially the code could be restructured so the link and tagline are part of the server core, and the theme just formats it, and the default could thdn be taken from the domain the instance is running under. But better not complicate things, the current situation is fine.

@estan estan closed this as completed Apr 1, 2020
@punkyard
Copy link

hi, yes, i don't fully agree, as the frame saying "Nextcloud – a safe home for all your data" covers part of the text at the bottom at the page. Could it be move to a small frame on the left? or in the top barre? or just removed?

contacts who receive a public file from us, have absolutely no need of the link to our login page. It's been many times confusing, especially with students.

So, i'd be happy to ask again for the deletion of this announcement at the bottom of the page. ✌️

thanks for your concern and all the good work done for your users

@Be-ing
Copy link

Be-ing commented Dec 29, 2024

I just ran into an issue where someone who didn't have an account was trying to fill out a public form but was unable to submit it because of this annoying banner on the bottom covering the Submit button on his phone, so yeah I think it's a bug that this shows by default.

@Be-ing
Copy link

Be-ing commented Dec 29, 2024

For anyone looking for a complete workaround via CLI:

occ config:system:set simpleSignUpLink.shown --type=boolean --value=false
occ theming:config name ""
occ theming:config slogan ""
occ theming:config url ""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug
Projects
None yet
Development

No branches or pull requests

4 participants