Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Feedback on Toolpad Core mention in MUI templates #4543

Open
1 of 5 tasks
prakhargupta1 opened this issue Dec 17, 2024 · 3 comments
Open
1 of 5 tasks

[docs] Feedback on Toolpad Core mention in MUI templates #4543

prakhargupta1 opened this issue Dec 17, 2024 · 3 comments
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation regression A bug, but worse

Comments

@prakhargupta1
Copy link
Member

prakhargupta1 commented Dec 17, 2024

Related page

https://mui.com/material-ui/getting-started/templates/#toolpad-core-beta

Issue description

Feedback on mui/material-ui#44415

@prakhargupta1 prakhargupta1 added the docs Improvements or additions to the documentation label Dec 17, 2024
@bharatkashyap
Copy link
Member

  1. These redirects should be in Toolpad repository.

I added these redirects on the Toolpad docs website but that alone wasn't enough to make the https://mui.com level redirection work: https://mui.com/toolpad/core/templates/nextjs-dashboard still returned a 404 page.

  1. Wrong light mode image size.
    Note: I rechecked the dark and light images, and the size is same. I can't figure out what's wrong.

👍🏻

  1. https://github.com/mui/material-ui/pull/44415/files#diff-6c8074cc0cbdc7ebecdca83a8bffea83d4b53608423228e56f0acbf9e050de80R27 to be moved under callout.

It's already under the callout, isnt it?

@prakhargupta1
Copy link
Member Author

It's already under the callout, isnt it?

Sorry, I think it was that the callout should be below: 'If you see any room for improvement, please feel free to open an issue or a pull request on GitHub.'

@oliviertassinari can you confirm?

@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 28, 2024

  1. I added these redirects on the Toolpad docs website but that alone wasn't enough to make the https://mui.com/ level redirection work: https://mui.com/toolpad/core/templates/nextjs-dashboard still returned a 404 page.

Right ok, I didn't realize this was a 200. I thought it was a 3XX. In this case, this makes sense. https://docs.netlify.com/routing/redirects/rewrites-proxies/ explains why. We would need to pay more.

By default, we limit internal rewrites to one “hop” — you cannot proxy from Netlify SiteA to Netlify SiteB to Netlify SiteC in a single request. This limitation may be amended for customers on a case-by-case basis. Contact support for more information.


  1. It's already under the callout, isnt it?

What if it was inside the callout?


I have added a new point 5. for Vercel hosting, so we use an org account.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work regression A bug, but worse labels Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation regression A bug, but worse
Projects
None yet
Development

No branches or pull requests

3 participants