Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @toolpad/core to React 19 #4499

Open
bharatkashyap opened this issue Dec 2, 2024 · 2 comments · May be fixed by #4488
Open

Update @toolpad/core to React 19 #4499

bharatkashyap opened this issue Dec 2, 2024 · 2 comments · May be fixed by #4488
Labels
core Infrastructure work going on behind the scenes

Comments

@bharatkashyap
Copy link
Member

No description provided.

@bharatkashyap bharatkashyap converted this from a draft issue Dec 2, 2024
@bharatkashyap bharatkashyap added the core Infrastructure work going on behind the scenes label Dec 2, 2024
@bharatkashyap bharatkashyap linked a pull request Dec 2, 2024 that will close this issue
@jy95
Copy link

jy95 commented Dec 7, 2024

+1

@kirill-konshin
Copy link

kirill-konshin commented Dec 29, 2024

At the very least the return from useActionState should be compatible with signIn prop of SignInPage:

const [whatever, action, isPending] = useActionState(
  async (_, formData) => {
    // logic
  },
  {},
);

// this one works but emits error in console
<SignInPage signIn={(provider, formData) => action(formData)} />

// this one results in full screen error
<SignInPage signIn={action} />

Error: An async function was passed to useActionState, but it was dispatched outside of an action context. This is likely not what you intended. Either pass the dispatch function to an action prop, or dispatch manually inside startTransition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

3 participants