Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button with icons #412

Closed
amitquest opened this issue Nov 7, 2024 · 2 comments
Closed

Button with icons #412

amitquest opened this issue Nov 7, 2024 · 2 comments
Assignees
Labels
duplicate This issue or pull request already exists figma

Comments

@amitquest
Copy link

amitquest commented Nov 7, 2024

Steps to reproduce

Link to live example: https://www.figma.com/design/lNGFVHPHGplTStkVyH6uZ1/MUI-for-Figma---Buttons-with-icons-height-and-vertical-centre-issue?node-id=3-204&t=NHs6Xu5Qr22onwdl-1

Steps:

  1. Drop button, change size to small, change to outline enable both icons

Current behavior

  1. The icons in the Small/Medium Outline and Text buttons are not in the vertical center.
  2. The size of the Small button height increases from 30 to 32 when the icons are enabled.

Expected behavior

  1. The icons should be in the vertical center in Small/Medium Outline/Text buttons
  2. The Small Solid/Outline/Text button height size should remain 30px when the icons are enabled.

Context

Design height and vertical alignment consistency similar to MUI

Your environment

Software Version
Design file version v5.17.0
Design tool Figma

Search keywords: Button Medium/Small vertical alignment with icons and Small button height with icons

@amitquest amitquest added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Nov 7, 2024
@zannager zannager added the figma label Nov 7, 2024
@adrianmanea
Copy link
Collaborator

adrianmanea commented Nov 11, 2024

Hi, we are aware of the problem! Here's the open issue associated with this: #408 and see how you can quickly solve it.

@adrianmanea adrianmanea removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Nov 15, 2024
@oliviertassinari oliviertassinari added the duplicate This issue or pull request already exists label Dec 22, 2024
@oliviertassinari
Copy link
Member

Duplicate of #408

@oliviertassinari oliviertassinari marked this as a duplicate of #408 Dec 22, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists figma
Projects
None yet
Development

No branches or pull requests

4 participants