Skip to content
This repository has been archived by the owner on Jul 13, 2018. It is now read-only.

Languages should not be defined in app.html. #12

Open
mythmon opened this issue Aug 8, 2013 · 1 comment
Open

Languages should not be defined in app.html. #12

mythmon opened this issue Aug 8, 2013 · 1 comment

Comments

@mythmon
Copy link
Contributor

mythmon commented Aug 8, 2013

The list of supported languages changes from time to time, and having it in a single several hundred character line in an html file is not ok.

@shuhaowu
Copy link
Contributor

shuhaowu commented Aug 9, 2013

Actually since right now most of the app is only localized in English and Chinese, that list is mostly a lie.

My initial design involved querying sumo for the language list. That added to the complexity of the app (as it would be an ajax call and hence more promises). I also tried to approach of querying sumo on the flask server boot and injected it directly in the app. That also added complexity to the flask server.

Ideally this would share the same list under kitsune/settings.py. I'm not sure what the best practice would be. Though since this is static enough, I feel like it should be okay. Although if there are better ideas...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants