-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Chatbot functions in SDK #178
base: main
Are you sure you want to change the base?
Conversation
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
mindsdb_sdk/chatbot.py
Outdated
@@ -0,0 +1,174 @@ | |||
from typing import List |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is the double of chatbots.py, isn't ?
mindsdb_sdk/chatbots.py
Outdated
data=payload | ||
) | ||
|
||
if inplace: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What could be the reason to update chatbot on server and not update local instance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's no reason for it 😅😅
Example usage: | ||
>>> chatbot.delete() | ||
""" | ||
self.api.delete_chatbot(self.project.name, self.name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is chatbots.drop(name) method for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be used to delete chatbot through it's instance instead of name.
shoud i remove this?
|
||
def __repr__(self): | ||
return f"{self.__class__.__name__}({self.project.name}.{self.name})" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an idea what methods could be useful:
- maybe add 'start'/'stop' methods?
Also a user would be interested in last error message for chatbot. is it accessible via rest API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for start stop methos we cane change is_running.
but "last error message", i am unabe to get it clearly
fixes #165
py.sdk.mdb.mp4