Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In tail call scenario, netsh ebpf show verif command to verify all sections. #3884

Open
shpalani opened this issue Sep 30, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request P2 triaged Discussed in a triage meeting
Milestone

Comments

@shpalani
Copy link
Collaborator

shpalani commented Sep 30, 2024

Describe the feature you'd like supported

Currently, in a tail call scenario with more than one section, the netsh command for show verification only verifies the first section.
The user has to do 'netsh ebpf show sections' and then provide each section to the netsh ebpf show verification command to verify all sections.
netsh ebpf show verification program.o section=xx type=yy verbose

The request is to verify all sections, as default.

Proposed solution

The request is to verify all sections, as default.

netsh ebpf show verification program.o

Additional context

No response

@shpalani shpalani added the enhancement New feature or request label Sep 30, 2024
@shankarseal shankarseal added the P2 label Sep 30, 2024
@shankarseal shankarseal added this to the 2411 milestone Sep 30, 2024
@shankarseal shankarseal added the triaged Discussed in a triage meeting label Sep 30, 2024
@shpalani
Copy link
Collaborator Author

shpalani commented Sep 30, 2024

Suggestion:
netsh ebpf show verification .o type=xdp can internally get all the sections (non-bpf2bpf), iterate through each section, verify and display the result.
For e.g,
netsh ebpf show ver bpf_xdp.o type=xdp verbose
section 2/16: Verification succeeded
section 2/18: Verification failed
..Verification error..
section 2/17: Verification succeeded.

@Alan-Jowett
Copy link
Member

@dthaler libbpf uses the following heuristic to differentiate sub-programs:
https://github.com/libbpf/libbpf/blob/caa17bdcbfc58e68eaf4d017c058e6577606bf56/src/libbpf.c#L4390C1-L4393C2

@shankarseal shankarseal modified the milestones: 2411, 2501 Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 triaged Discussed in a triage meeting
Projects
None yet
Development

No branches or pull requests

4 participants