Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cljfmt to keep code consistent and beautiful #86

Open
3 tasks
crisptrutski opened this issue Aug 21, 2024 · 2 comments
Open
3 tasks

Use cljfmt to keep code consistent and beautiful #86

crisptrutski opened this issue Aug 21, 2024 · 2 comments
Labels
developer experience Make developer's lives better good first issue Good for newcomers

Comments

@crisptrutski
Copy link
Collaborator

  • Match the configuration for Metabase
  • Check formatting in git hook
  • Check formatting in CI
@crisptrutski crisptrutski added good first issue Good for newcomers developer experience Make developer's lives better labels Aug 21, 2024
@crisptrutski
Copy link
Collaborator Author

With default settings, it's pretty unhappy with us:

❯ cljfmt check | wc -l
src/macaw/util.clj has incorrect formatting
src/macaw/rewrite.clj has incorrect formatting
test/macaw/core_test.clj has incorrect formatting
test/macaw/acceptance_test.clj has incorrect formatting
4 file(s) formatted incorrectly
     201

@crisptrutski
Copy link
Collaborator Author

We've reformatted it with default settings, only thing left is automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer experience Make developer's lives better good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant