-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automation #40
Comments
@jcbhmr i'd love to add some automation! the thing is i just didn't spend the time yet into looking into everything that's possible and how to actually set everything up. I set up Github Actions for my main project for work and I must say it has been such a time-suck and keeps putting me into tooling hell without making any actual progress on the actual codebase that I've been rather reluctant into introducing it into smaller npm packages. 😅 That being said, if you are able to set up some small & low-maintenance Github Actions then I'm very open to merging that PR! |
I note that you mentioned you want to keep this package relatively simple. I personally find the "dev" "production" branches highly confusing and over-complicated for what I assumed was the basic workflow of:
Would it be worthwhile to either simplify/normalize this process and/or document it somewhere as to how your package management & release workflow works? I usually do a "development" blurb section in my readmes like this: |
I also think that removing dist from source control is a good step to simplify the workflow of stuff too. That way you don't need to commit your build artifacts, you just generate those in the publish.yml workflow when running |
This comment was marked as off-topic.
This comment was marked as off-topic.
before I was thinking I'd need to have a production and dev branch separate so I can merge everything from However, I then came to the realisation I just execute this is actually a pretty great CLI experience where you can choose the bump type, then it bumps for you, but it also auto creates the tag & creates a release on github releases with a list of all the commits included in that release, these: https://github.com/mesqueeb/is-what/releases The publish workflow we recently added now will just fail because I use
|
I personally don't mind it. I don't see any downsides tbh. What do I like to be able to see what changes to the build pipeline actually change in the |
This comment was marked as outdated.
This comment was marked as outdated.
I think if you really want this you can use https://github.com/actions/upload-artifact with |
Guess what! 🥳 I found a pretty good workflow that I think ticks all (most) the boxes for the version thing!
https://github.com/del-systems/check-if-version-bumped - uses: del-systems/check-if-version-bumped@v1 That way when you open a PR that matches *the patterns* for Node.js source code, it'll trigger this job to check the package.json bumping. 🛑 CAVEAT: It doesn't know if the change was major, minor, or patch; it just wants the version to be bumped! This is good enough for ALMOST EVERYTHING since the main thing you want to prevent is the classic: "I forgot to bump the version in the PR..." mistake! 🤣 |
Original issue
GitHub Actions can do a lot of magic stuff for you! Here's some things that a lot of npm packages have that might be interesting to add to this project:
npm test
on each Node LTS versionnpm publish
with an npm token on each releaseThings to automate:
npm publish
deno/
-prefixed release tag on abuild
branchtypedoc
generated documentation website to GitHub Pagesnpm test
on Node.js LTS versionspackage.json
version
property has changedThe text was updated successfully, but these errors were encountered: