Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: dynamic thresholding changes secondary sampler name #65

Open
afbagwell opened this issue Sep 2, 2023 · 1 comment
Open

Bug: dynamic thresholding changes secondary sampler name #65

afbagwell opened this issue Sep 2, 2023 · 1 comment

Comments

@afbagwell
Copy link

afbagwell commented Sep 2, 2023

Brief description: When saving an image in SD.Next, the dynamic thresholding extension is changing the name of the latent sampler in the image's recorded metadata by appending "_dynthresXXX" characters to the end. This is transposed back to latent sampler name field when feeding the image metadata to the Text2Image tab causing it to name a sampler that doesn't exist.

In looking at the code, it appears that when issue #58 was implemented, somehow the thresholding name for the latent sampler is being restored as the latent sampler's original name.

Linking to the bug explanation as originally posted on the SD.Next issues page:

vladmandic/automatic#2124

@afbagwell
Copy link
Author

I don't have a fix for this, but I ran a few tests on the code, specifically in dynamic_thresholding.py, lines 163 and 180.

Lines 179-181 correctly restore the names of each sampler, however by that point it appears that the metadata has already been recorded (or copied for later recording) with the altered latent sampler name? It's not clear to me why this same bug doesn't also affect the primary sampler name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant