-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart "Lines used" cannot exceed 10 #48
Comments
@andykais I reproduced your issue. chart is actually seeing all your lines as shown in the first line of output. The |
If you look at the README short video you can see an example of the same behaviour: |
hey @marianogappa, Im aware that it condensed down the last x categories into "Other". I probably should have framed this issue better, but my question is if there is a way to display all categories rather than condensing them down. Is this some sort of memory safety thing? |
It is hardcoded unfortunately: https://github.com/marianogappa/chart/blob/master/freq.go#L37 It's really not a memory thing. A pie chart with more than 10 items doesn't really tell a very useful story. Typically any pie chart in a presentation or article will either have less categories or some aggregation. You may argue that this should be up for the client and not the tool to decide. My rationale was to provide a sensible default behaviour. It does make sense to provide an override, but I didn't want to make the tool too complicated. Please refer to my rationale for that in the Contributing section: https://github.com/marianogappa/chart/blob/master/freq.go#L37 I do think it's a fair enough override, but first I'd like to see how useful it really is to have a pie chart where you can barely see the slices. |
this is best outlined with this output from this bash script (which is taken from the readme)
there are far more commands used in my history than 10, but it seems like the display never exceeds 10. It just ends up lumping thousands of commands into a column "Other". This is true for various other graphs I attempt as well (at least simple string frequency graphs that I know how to use)
This appears to be by design, is there a way to tell
chart
to just graph "everything"?The text was updated successfully, but these errors were encountered: