Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grading key view in the course statistics is displayed squished for students #10017

Open
maximiliansoelch opened this issue Dec 13, 2024 · 5 comments · May be fixed by #10051
Open

Grading key view in the course statistics is displayed squished for students #10017

maximiliansoelch opened this issue Dec 13, 2024 · 5 comments · May be fixed by #10051
Labels
assessment Pull requests that affect the corresponding module enhancement good first issue user interface

Comments

@maximiliansoelch
Copy link
Member

Describe the bug

When viewing the bonus rules in the statistics tab as a student, the opened grading bonus view is displayed squished. In addition, the information text at the top appears twice.

To Reproduce

  1. Go to 'Statistics'
  2. Click on 'View Bonus Rules'
  3. See the squished grading key view and the duplicated info text at the top.

Expected behavior

The view should take the whole horizontal space and the info text should only be displayed once.

Screenshots

image

Which version of Artemis are you seeing the problem on?

7.7.5

What browsers are you seeing the problem on?

Safari

Additional context

No response

Relevant log output

No response
@github-actions github-actions bot added assessment Pull requests that affect the corresponding module lecture Pull requests that affect the corresponding module labels Dec 13, 2024
@maximiliansoelch maximiliansoelch added good first issue and removed lecture Pull requests that affect the corresponding module labels Dec 13, 2024
@laxerhd
Copy link
Contributor

laxerhd commented Dec 13, 2024

I would like to fix that.

@laxerhd
Copy link
Contributor

laxerhd commented Dec 14, 2024

I removed the duplicate text and changed the width of the table, but I'm not sure if it looks worse now.
First of all, there is not much information there, so it might look better if the table is just centered.
What do you think?

Full width:
image

Centered:
image

@maximiliansoelch
Copy link
Member Author

Personally, I like the centered version more.

@rabeatwork What do you think?

@rabeatwork
Copy link
Contributor

Personally, I like the centered version more.

@rabeatwork What do you think?

I would also go with the centered version. Otherwise, it can be really hard to match the bonus points to the corresponding interval, especially on big screens.

@laxerhd
Copy link
Contributor

laxerhd commented Dec 17, 2024

Agreed, will open a PR in the next few days.

@laxerhd laxerhd linked a pull request Dec 19, 2024 that will close this issue
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assessment Pull requests that affect the corresponding module enhancement good first issue user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Assessment: Remove duplicate message and center table ls1intum/Artemis
3 participants
@maximiliansoelch @rabeatwork @laxerhd