Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression] images in tables now displayed with bad ratio/stretched #173

Open
1 of 2 tasks
cannibalox opened this issue Nov 24, 2024 · 1 comment
Open
1 of 2 tasks
Assignees

Comments

@cannibalox
Copy link

Search first

  • I searched and no similar issues were found

What Happened?

images in tables are now displayed with a bad aspect ratio/stretched :
image

see Commit 27d7307

Reproduce the Bug

open a table with images in cells

Expected Behavior

images aspect ratio should be kept untouched
image

Screenshots

No response

Browser, Desktop or Mobile Platform Information

test build 99bf950

Additional Context

No response

Are you willing to submit a PR? If you know how to fix the bug.

  • I'm willing to submit a PR (Thank you!)
@cannibalox
Copy link
Author

hi, more feedback, this time using build 5e68c3e (2024-11-27 19:00 CET)

so now image is in good AR, but it seems there is potential wasted space around images (lot of empty space around the posters) :
ss_20241127_catsxp_xePb1g3es4

a quick test with

.ls-table img {
    max-height: 100%;
    max-width: 98% !important;
    overflow: hidden;
}

seems to make better use of the cell space, but I'm not sure if there are any drawbacks :
ss_20241127_catsxp_fqJurdUeKw
ss_20241127_catsxp_fyL9kjnJ7V

from a user standpoint, I would prefer if images would fill the available space, but again, I'm not aware of requirements or implications elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants