Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: fix custom max_token not saved via customModelCards form #5226

Merged
merged 2 commits into from
Dec 29, 2024

Conversation

hezhijie0327
Copy link
Contributor

@hezhijie0327 hezhijie0327 commented Dec 29, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

修复自定义模型更改 max_token 未生效的问题

问题复现:

  1. 创建/修改自定义模型
  2. 修改最大 Token 数量
  3. 保存设置

image

📝 补充信息 | Additional Information

Before After
image image

Copy link

vercel bot commented Dec 29, 2024

@hezhijie0327 is attempting to deploy a commit to the LobeHub Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐛 Bug Something isn't working | 缺陷 labels Dec 29, 2024
@lobehubbot
Copy link
Member

👍 @hezhijie0327

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.12%. Comparing base (ea7e732) to head (1c7b9db).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main    #5226     +/-   ##
=========================================
  Coverage   92.12%   92.12%             
=========================================
  Files         570      570             
  Lines       43517    43517             
  Branches     2556     3890   +1334     
=========================================
  Hits        40089    40089             
  Misses       3428     3428             
Flag Coverage Δ
app 92.12% <ø> (ø)
server 97.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arvinxx arvinxx merged commit ab6d17c into lobehub:main Dec 29, 2024
5 of 7 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @hezhijie0327 ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request Dec 29, 2024
### [Version&nbsp;1.42.1](v1.42.0...v1.42.1)
<sup>Released on **2024-12-29**</sup>

#### 🐛 Bug Fixes

- **misc**: Fix custom max_token not saved from customModelCards.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix custom max_token not saved from customModelCards, closes [#5226](#5226) ([ab6d17c](ab6d17c))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.42.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@hezhijie0327 hezhijie0327 deleted the form_token branch December 29, 2024 07:06
github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Dec 29, 2024
### [Version&nbsp;1.84.1](v1.84.0...v1.84.1)
<sup>Released on **2024-12-29**</sup>

#### 🐛 Bug Fixes

- **misc**: Fix custom max_token not saved from customModelCards.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix custom max_token not saved from customModelCards, closes [lobehub#5226](https://github.com/bentwnghk/lobe-chat/issues/5226) ([ab6d17c](ab6d17c))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working | 缺陷 released size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants