Fix metal build #513
Merged
Fix metal build #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Green-Sky
reviewed
Dec 7, 2024
| @@ -161,7 +161,7 @@ class StableDiffusionGGML { | |||
| #endif | |||
| #ifdef SD_USE_METAL | |||
| LOG_DEBUG("Using Metal backend"); | |||
| ggml_backend_metal_log_set_callback(ggml_log_callback_default, nullptr); | |||
| ggml_log_set(ggml_log_callback_default, nullptr); | |||
There was a problem hiding this comment.
I don't think this should be inside of the ifdef.
There was a problem hiding this comment.
you're probably right. I just replaced 1 to 1 to make sure I'm not breaking other backends as a side effect.
|
Could we pass the PR? I have the same problem for MacOS build. |
|
Thank you for your contribution. |
stduhpf
added a commit
to stduhpf/stable-diffusion.cpp
that referenced
this pull request
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some ggml API changes were causing metal builds to fail.
Fixes #512