Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ftr] Improve integration suite with file downloads #80

Open
l3nz opened this issue Nov 3, 2019 · 1 comment
Open

[Ftr] Improve integration suite with file downloads #80

l3nz opened this issue Nov 3, 2019 · 1 comment
Labels
starter issue Good for newcomers

Comments

@l3nz
Copy link
Owner

l3nz commented Nov 3, 2019

Is your feature request related to a problem? Please describe.

It is important to have an integration suite that actually exercises important features.
At the moment we don't exercise HTTP download for CLJS and no file download/coercion (JSON, YAML, etc) for CLJ.

Describe the solution you'd like

One could download files from GitHub, e.g. from here: https://github.com/l3nz/cli-matic/tree/master/examples-cljs-planck/data

This should work trivially when replicating https://github.com/l3nz/cli-matic/blob/master/examples-cljs-planck/read-file.cljs in the CLJ area.

The problem is that the world is HTTPS now, and Planck crashes on HTTPS. Any chance of downloading from GitHub as HTTP?

Tests are to be added at

# bash -c './exit-status.cljs exit --mode ONE || echo "xxx $?"'

@l3nz l3nz added the starter issue Good for newcomers label Nov 3, 2019
@l3nz
Copy link
Owner Author

l3nz commented Nov 3, 2019

Maybe this could hlp somehow? https://docs.postman-echo.com/?version=latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
starter issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant