Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password Settings not Supported #79

Open
hugosenari opened this issue Mar 13, 2017 · 5 comments
Open

Password Settings not Supported #79

hugosenari opened this issue Mar 13, 2017 · 5 comments

Comments

@hugosenari
Copy link

Current version can't use plugin_support.UserNamePassword as plugin setting type.

Actual Behaviour

raise ImportError "Keyring is not supported"

Expected Behaviour

Maybe use Keyring to implement this feature.

@hugosenari
Copy link
Author

Added three possible solutions for this:

I created the first (and last) option because plugins can define other auth strategy (IE. OAuth) and fields.

@bluss
Copy link
Member

bluss commented Mar 22, 2017

I haven't used the keyring support before. Does it work well for you?

I'm skeptical of it: when I look at GData APIs (google) all the user+pass authorization options seem deprecated, and I would prefer if we didn't have to handle passwords at all.

Either way I also hope that user sources may be a back door in for users to do all kinds of data gathering that they'd like.

@hugosenari
Copy link
Author

Keyring support works fine to me, but I don't know for edge cases or tested with all kind of backends.

I had this issues with Jira Plugin:

  • How old kupfer handle OAuth or SAML flow?
    • It doesn't, so I can only enable User/Pass auth.
  • How new kupfer store pass?
    • It doesn't, then to support new kupfer version pass is text/plain.

User sources can't make new actions (call webservices in my case).

I'm not defending my implementation only that some is required.
I'll be glad if we can find plugin solution that doesn't change kupfer.

@bluss
Copy link
Member

bluss commented Mar 23, 2017

We should add back the UserNamePassword setting type I think.

UserNamePassword2 looks good to me. Does it need more error handling?

@hugosenari
Copy link
Author

Added error if backend is fail.Keyring.
Removed check if is encrypted and add name.
Ge/Set pass can raise errors, they shows at stdout and don't crash kupfer settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants