-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Password Settings not Supported #79
Comments
Added three possible solutions for this:
I created the first (and last) option because plugins can define other auth strategy (IE. OAuth) and fields. |
I haven't used the keyring support before. Does it work well for you? I'm skeptical of it: when I look at GData APIs (google) all the user+pass authorization options seem deprecated, and I would prefer if we didn't have to handle passwords at all. Either way I also hope that user sources may be a back door in for users to do all kinds of data gathering that they'd like. |
Keyring support works fine to me, but I don't know for edge cases or tested with all kind of backends. I had this issues with Jira Plugin:
User sources can't make new actions (call webservices in my case). I'm not defending my implementation only that some is required. |
We should add back the UserNamePassword setting type I think. UserNamePassword2 looks good to me. Does it need more error handling? |
Added error if backend is fail.Keyring. |
Current version can't use plugin_support.UserNamePassword as plugin setting type.
Actual Behaviour
raise ImportError "Keyring is not supported"
Expected Behaviour
Maybe use Keyring to implement this feature.
The text was updated successfully, but these errors were encountered: