Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing input sanitation #26

Open
xhenner opened this issue Oct 6, 2021 · 0 comments
Open

Missing input sanitation #26

xhenner opened this issue Oct 6, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@xhenner
Copy link

xhenner commented Oct 6, 2021

There are some sanity checks that should be added.

If you try echo "rgb" > /run/g13d/g13-0 or echo "dump" > /run/g13d/g13-0, the program fails with a core dump.

I'm not familiar with C++ and cannot provide a MR to fix that :( but a bad command should return an error, not crashing the program
@khampf khampf added the bug Something isn't working label Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@khampf @xhenner