Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: oci genai chat models #1337

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anders-swanson
Copy link
Contributor

@anders-swanson anders-swanson commented Dec 2, 2024

Feature: add support for OCI Cohere and Llama chat models. Remove older GenerateText request format.

Closes #1334

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

Signed-off-by: Anders Swanson <[email protected]>
@anders-swanson anders-swanson requested review from a team as code owners December 2, 2024 20:39
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 82 lines in your changes missing coverage. Please review.

Project coverage is 33.86%. Comparing base (173e4dc) to head (e8271e5).
Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ai/ocigenai.go 0.00% 82 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1337      +/-   ##
==========================================
- Coverage   34.76%   33.86%   -0.91%     
==========================================
  Files          94       97       +3     
  Lines        6342     6550     +208     
==========================================
+ Hits         2205     2218      +13     
- Misses       4046     4240     +194     
- Partials       91       92       +1     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@anders-swanson
Copy link
Contributor Author

Could I get some eyes on this PR? This patch will remove deprecated APIs for the OCI provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Proposed
1 participant