Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change type of index labels from slice to range #58

Open
telamonian opened this issue Dec 17, 2020 · 0 comments
Open

change type of index labels from slice to range #58

telamonian opened this issue Dec 17, 2020 · 0 comments
Labels
tag:backend general issues with the python backend tag:frontend general issues with the typescript frontend tag:refactor type:enhancement

Comments

@telamonian
Copy link
Member

telamonian commented Dec 17, 2020

having the type of the index labels be a list of python slice objects on the python side and an array of ISlice objects on the typescript side is, at best, very confusing. I'm essentially using each "slice" here to define a range of index values, so let's just call these things range (python) and IRange (typescript) instead.

To clarify, I'm proposing simply to change the names of these types, not any behavior

@telamonian telamonian added tag:backend general issues with the python backend tag:frontend general issues with the typescript frontend tag:refactor type:enhancement labels Dec 17, 2020
@telamonian telamonian added this to the 0.6.0 milestone Dec 17, 2020
@loichuder loichuder removed this from the 0.6.0 milestone Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:backend general issues with the python backend tag:frontend general issues with the typescript frontend tag:refactor type:enhancement
Projects
None yet
Development

No branches or pull requests

2 participants