Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DialogModule Asset #1491

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

time-killer-games
Copy link

@time-killer-games time-killer-games commented Oct 1, 2024

  • Fixes: DialogModule should be updated. (IMO) #1490 - updates DialogModule extension.
  • Adds the libzoom extension, which is cross-platform; maximizes the main window on start-up.
  • Replace Execute Shell Simple with xProcess to get Folder/URL opening feature to work (Mac).

Looking at code you commented out it seems like you were using xProcess originally. Not sure why you replaced it with Execute Shell Simple when all that does is make code that previously worked, and cross-platform, no longer work, at all.

Just speculation, but if why you took out xProcess had anything to do with virus scanners throwing a false positive on it, that was an issue I was able to reproduce on my end, and I found out why it was doing that, and how to fix it, since then. 👍

It no longer has that problem in the latest builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DialogModule should be updated. (IMO)
1 participant