Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on fn key press #1453

Open
sevonj opened this issue Dec 5, 2024 · 4 comments
Open

Crash on fn key press #1453

sevonj opened this issue Dec 5, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@sevonj
Copy link

sevonj commented Dec 5, 2024

Describe the bug
Pressing the function key causes an instant crash. This happens when a book or a catalog is open. It doesn't occur in the library view.

To Reproduce
Steps to reproduce the behavior:

  1. Open a book OR open a catalog
  2. Press fn key

Expected behavior
The app should survive a key press.

Screenshots

Version:

  • Foliate version: 3.2.0
  • OS/Distribution and version: Vanilla OS 2.0
  • Desktop environment: Gnome 46
  • Installation method: Flatpak (Flathub)

Additional context

So, the device is an old 2013 macbook air with finnish keyboard layout. Either of those things, or both may be relevant. System language is en-us.

console output
MESA-INTEL: warning: Haswell Vulkan support is incomplete
MESA-INTEL: warning: ../src/intel/vulkan_hasvk/anv_formats.c:752: FINISHME: support YUV colorspace with DRM format modifiers
MESA-INTEL: warning: ../src/intel/vulkan_hasvk/anv_formats.c:783: FINISHME: support more multi-planar formats with DRM modifiers

(com.github.johnfactotum.Foliate:2): Gdk-�[1;33mWARNING�[0m **: �[34m17:45:23.395�[0m: vkAcquireNextImageKHR(): A swapchain no longer matches the surface properties exactly, but can still be used to present to the surface successfully. (VK_SUBOPTIMAL_KHR) (1000001003)

(com.github.johnfactotum.Foliate:2): com.github.johnfactotum.Foliate-�[1;33mWARNING�[0m **: �[34m17:45:24.743�[0m: Gio.IOErrorEnum: GDBus.Error:org.gtk.GDBus.UnmappedGError.Quark._g_2dio_2derror_2dquark.Code1: Service 'dbus:org.freedesktop.Tracker3.Miner.Files' not found in Tracker policy
getURIFromTracker@resource:///com/github/johnfactotum/Foliate/library.js:83:60
get@resource:///com/github/johnfactotum/Foliate/library.js:121:42
getBookFromIdentifier@resource:///com/github/johnfactotum/Foliate/library.js:169:36
getBook@resource:///com/github/johnfactotum/Foliate/library.js:166:21
activate@resource:///com/github/johnfactotum/Foliate/library.js:899:63
activate@resource:///com/github/johnfactotum/Foliate/library.js:391:18
_init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:263:34
  
Failed to create /home/username/.var/app/com.github.johnfactotum.Foliate/cache for shader cache (No such file or directory)---disabling.
Failed to create /home/username/.var/app/com.github.johnfactotum.Foliate/cache for shader cache (No such file or directory)---disabling.

(com.github.johnfactotum.Foliate:2): Gtk-�[1;35mCRITICAL�[0m **: �[34m17:45:26.892�[0m: invalid accelerator string '0x100811d0'

The last line looks like a hint.

better sys details
# System Details Report
---

## Report details
- **Date generated:**                              2024-12-05 14:27:09

## Hardware Information:
- **Hardware Model:**                              Apple Inc. MacBookAir6,2
- **Memory:**                                      8,0 GiB
- **Processor:**                                   Intel® Core™ i5-4250U × 4
- **Graphics:**                                    Intel® HD Graphics 5000 (HSW GT3)
- **Disk Capacity:**                               121,3 GB

## Software Information:
- **Firmware Version:**                            432.60.3.0.0
- **OS Name:**                                     Vanilla OS 2.0
- **OS Build:**                                    (null)
- **OS Type:**                                     64-bit
- **GNOME Version:**                               46
- **Windowing System:**                            Wayland
- **Kernel Version:**                              Linux 6.9.8-amd64
@sevonj sevonj added the bug Something isn't working label Dec 5, 2024
@johnfactotum
Copy link
Owner

I'm inclined to say that this is not our bug because I don't think Foliate is getting any accel string anywhere, much less passing such strings to to anything. On top of that, there's no shortcut specific to the catalogs view.

If it doesn't happen when there's no WebView, it might be a WebKitGTK issue, though one might be able to disprove this if one is able to press fn without crashing other WebKitGTK apps.

@sevonj
Copy link
Author

sevonj commented Dec 5, 2024

It's unfortunate if nothing can be done on this end, since the app has been pretty crashy for me. I also experienced the one where just opening catalogs or books crashes the app, while fiddling with locales, but haven't yet attempted to reproduce it.

@johnfactotum
Copy link
Owner

Crashing caused by mixed locales is a known Flatpak bug.

@sevonj
Copy link
Author

sevonj commented Dec 6, 2024

I tested fully finnish and fully us-english settings, including keyboard layouts, just in case (full reboots between). That didn't make a difference, so I guess it can be ruled out. Couldn't reproduce the other one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants