Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to click on a font twice before it gets set on a fresh launch #1449

Open
Sunspark-007 opened this issue Dec 4, 2024 · 3 comments
Open
Labels
bug Something isn't working

Comments

@Sunspark-007
Copy link

Describe the bug
In the selector, serif fonts, when you freshly launch it and select a font, it doesn't change or set even though the name changes. You have to go back and select it a second time before the page display changes and it stays at that setting.

To Reproduce
Steps to reproduce the behavior:

  1. Launch Foliate flatpak
  2. Serif in the font selector
  3. Select a font

Expected behavior
For the font on the page to change on the first click selection.

Version:

  • Foliate version: 3.2.0
  • OS/Distribution and version: SteamOS 3.6.20
  • Desktop environment: KDE
  • Installation method: Flatpak
@Sunspark-007 Sunspark-007 added the bug Something isn't working label Dec 4, 2024
@johnfactotum
Copy link
Owner

I don't seem to be able to reproduce this issue. By "even though the name changes", do you mean the text in the font button successfully changes? Is there any error message if you run it from the terminal?

@Sunspark-007
Copy link
Author

Ok this is strange.. when I launch it from the terminal, it wasn't doing what I am reporting.. but when launching it from the favorites menu, then it did do the thing I am reporting. Tried again with the terminal and it had the issue.

I wonder if it's related to the first font in the list (Gentium) or if it's something to do with the terrible font picker. I hate the GTK font picker very much because for whatever reason, in this and one other app it displays the font names in random order instead of alphabetical, and is extremely slow when typing in the names. I have to wait for the keypresses to appear, otherwise it is out of order.

Terminal output below. Criticals at the end are from hitting X to close the window.

(deck@steamdeck ~)$ flatpak run com.github.johnfactotum.Foliate
(com.github.johnfactotum.Foliate:2): com.github.johnfactotum.Foliate-WARNING **: 02:17:56.633: Gio.IOErrorEnum: GDBus.Error:org.gtk.GDBus.UnmappedGError.Quark._g_2dio_2derror_2dquark.Code1: Service 'dbus:org.freedesktop.Tracker3.Miner.Files' not found in Tracker policy
getURIFromTracker@resource:///com/github/johnfactotum/Foliate/library.js:83:60
get@resource:///com/github/johnfactotum/Foliate/library.js:121:42
getBookFromIdentifier@resource:///com/github/johnfactotum/Foliate/library.js:169:36
getBook@resource:///com/github/johnfactotum/Foliate/library.js:166:21
activate@resource:///com/github/johnfactotum/Foliate/library.js:899:63
activate@resource:///com/github/johnfactotum/Foliate/library.js:391:18
_init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:263:34
(com.github.johnfactotum.Foliate:2): com.github.johnfactotum.Foliate-WARNING **: 02:17:58.418: GdkPixbuf.PixbufError: Unrecognized image file format
base64ToPixbuf@resource:///com/github/johnfactotum/Foliate/utils.js:175:33
_init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:263:34
(com.github.johnfactotum.Foliate:2): Gjs-CRITICAL **: 02:19:50.974: Attempting to run a JS callback during shutdown. This is most likely caused by destroying a Clutter actor or GTK widget with ::destroy signal connected, or using the destroy(), dispose(), or remove() vfuncs. Because it would crash the application, it has been blocked.
The offending callback was ListBoxUpdateHeaderFunc().
== Stack trace for context 0x55c3a7313820 ==
(com.github.johnfactotum.Foliate:2): Gjs-CRITICAL **: 02:19:50.974: Attempting to run a JS callback during shutdown. This is most likely caused by destroying a Clutter actor or GTK widget with ::destroy signal connected, or using the destroy(), dispose(), or remove() vfuncs. Because it would crash the application, it has been blocked.
The offending callback was ListBoxUpdateHeaderFunc().
== Stack trace for context 0x55c3a7313820 ==
(com.github.johnfactotum.Foliate:2): Gjs-CRITICAL **: 02:19:50.974: Attempting to run a JS callback during shutdown. This is most likely caused by destroying a Clutter actor or GTK widget with ::destroy signal connected, or using the destroy(), dispose(), or remove() vfuncs. Because it would crash the application, it has been blocked.
The offending callback was ListBoxUpdateHeaderFunc().
== Stack trace for context 0x55c3a7313820 ==
(com.github.johnfactotum.Foliate:2): Gjs-CRITICAL **: 02:19:50.974: Attempting to run a JS callback during shutdown. This is most likely caused by destroying a Clutter actor or GTK widget with ::destroy signal connected, or using the destroy(), dispose(), or remove() vfuncs. Because it would crash the application, it has been blocked.
The offending callback was ListBoxUpdateHeaderFunc().
== Stack trace for context 0x55c3a7313820 ==
(com.github.johnfactotum.Foliate:2): Gjs-CRITICAL **: 02:19:50.974: Attempting to run a JS callback during shutdown. This is most likely caused by destroying a Clutter actor or GTK widget with ::destroy signal connected, or using the destroy(), dispose(), or remove() vfuncs. Because it would crash the application, it has been blocked.
The offending callback was ListBoxUpdateHeaderFunc().
== Stack trace for context 0x55c3a7313820 ==
(com.github.johnfactotum.Foliate:2): Gjs-CRITICAL **: 02:19:50.974: Attempting to run a JS callback during shutdown. This is most likely caused by destroying a Clutter actor or GTK widget with ::destroy signal connected, or using the destroy(), dispose(), or remove() vfuncs. Because it would crash the application, it has been blocked.
The offending callback was ListBoxUpdateHeaderFunc().
== Stack trace for context 0x55c3a7313820 ==
(com.github.johnfactotum.Foliate:2): Gjs-CRITICAL **: 02:19:50.975: Attempting to run a JS callback during shutdown. This is most likely caused by destroying a Clutter actor or GTK widget with ::destroy signal connected, or using the destroy(), dispose(), or remove() vfuncs. Because it would crash the application, it has been blocked.
The offending callback was ListBoxUpdateHeaderFunc().
== Stack trace for context 0x55c3a7313820 ==
(deck@steamdeck ~)$

@johnfactotum
Copy link
Owner

Well, it certainly looks like a strange issue. Just an idea: are you sure it's not working, or perhaps it's only taking a long time to re-render the page?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants