Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed reason field being shared between models. #1434

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

noamkush
Copy link

@noamkush noamkush commented Jan 2, 2025

Description

This fixes the custom reason field being shared between inherited models. It causes issues when calling update() on the historical model. When generating the field, a clone() call is added so the field wouldn't be shared.

Related Issue

Fixes #1433

How Has This Been Tested?

Added unit tests reproducing the issue. The tests fail on master branch.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the pre-commit run command to format and lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug using django ORM to update inherited history_change_reason field
1 participant