Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dumb-jump disables tab-bar-mode #455

Open
julian-hoch opened this issue Nov 28, 2024 · 2 comments
Open

dumb-jump disables tab-bar-mode #455

julian-hoch opened this issue Nov 28, 2024 · 2 comments

Comments

@julian-hoch
Copy link

julian-hoch commented Nov 28, 2024

Not quite sure why this is happening, but whenever I use dumb-jump, tab-bar-mode gets disabled, and I have to manually re-enable it afterwards.

This is my config:

  (use-package dumb-jump
    :config
    (add-hook 'xref-backend-functions #'dumb-jump-xref-activate)
    :custom
    (dumb-jump-prefer-searcher 'rg)
    (xref-show-definitions-function #'consult-xref)
    (xref-show-xrefs-function #'consult-xref)
    :bind
    ("M-g j" . dumb-jump-go)
    ("M-g o" . dumb-jump-go-other-window)
    ("M-g b" . dumb-jump-back))
@jacktasia
Copy link
Owner

When you say "use," do you mean when your config runs or anytime you use any of the bound dumb-jump-* commands? What version of emacs? I can't really see a way they could be connected. I enabled tab-bar-mode and using dumb-jump commands is not disabling it for me. Do you have your full emacs config available anywhere?

@julian-hoch
Copy link
Author

What I meant was that it happens when I run "dumb-jump-go". I do not have my full config online, but this is how I set it up:

  (pretty-hydra-define dumb-jump-hydra
    (:title "Dumb Jump" :quit-key "q" :color teal :hint nil)
    ("Jump"
     (("j" dumb-jump-go "jump")
      ("o" dumb-jump-go-other-window "other window")
      ("b" dumb-jump-back "back"))
     "Jump (external)"
     (("e" dumb-jump-go-prefer-external "jump")
      ("x" dumb-jump-go-prefer-external-other-window "other window"))
     "Other"
     (("p" dumb-jump-go-prompt "prompt")
      ("l" dumb-jump-quick-look "quick look"))))

I took that basically from the README. Now I noticed that in the documentation of "dumb-jump-go" it says:

This command is obsolete since 2020-06-26; dumb-jump-go has been
obsoleted by the xref interface.

So perhaps I am using it wrong? I also noticed that it does not use the minibuffer and instead a little dropdown popup.

If I use "xref-find-definitions" this does not happen, so perhaps I should switch to using that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants