Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtle Discrepancies in PBR Implementation #2337

Open
yaRnMcDonuts opened this issue Dec 29, 2024 · 0 comments
Open

Subtle Discrepancies in PBR Implementation #2337

yaRnMcDonuts opened this issue Dec 29, 2024 · 0 comments

Comments

@yaRnMcDonuts
Copy link
Member

yaRnMcDonuts commented Dec 29, 2024

The purpose of this issue is to keep track of potential issues that may be causing JME's final PBR render output to not match the Khronos standard.

I have personally noticed some PBR models having an extremely subtle foggy white glare to them. And I also recall a jme user years ago who was complaining that their shiny models look "plasticky" and incorrect in JME

Here are some probable issues to keep an eye on:

  1. This PR that addresses a potential math issue in the fZero and metallic calculation: Fix incorrect metallic calculations in PBRLighting.frag #2334
  2. JME's MikktSpaceTangentGenerator has many "todo" comments left in from 2016 by the original author (who is no longer around to maintain things) that may indicate issues in the functionality. There have been no apparent major issues in jme's tangents, however there is still the possibility that jme's tangents don't match the industry standard for MikktSpace which could effect the final rendering of PBR models with normal maps. (https://hub.jmonkeyengine.org/t/mikktspacetangentgenerator-fails-with-npe/48114/9)

Please comment here if you think that you may have found any other issues with jme's PBR implementation, or if you are knowledgeable about any of the items currently in the list. Thanks.

@yaRnMcDonuts yaRnMcDonuts added this to the Future Release milestone Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant