Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: scoped: true / SSR components incorrectly resolve <slot /> during first render #6080

Open
3 tasks done
johnjenkins opened this issue Dec 17, 2024 · 0 comments
Open
3 tasks done

Comments

@johnjenkins
Copy link
Contributor

johnjenkins commented Dec 17, 2024

Prerequisites

Stencil Version

latest

Current Behavior

When hydrating scoped: true via SSR, Stencil's vdom-render incorrectly re-renders / does not resolve slot nodes.
This results in incorrect ordering as nodes are remove / re-inserted

image

Expected Behavior

Nodes in correct order. No extra re-renders

System Info

No response

Steps to Reproduce

Open https://stackblitz.com/edit/stencil-start-ydmeww :

npm run build && npm run express

In the preview window, click on 'non-shadow-multi-slots'.

Notice nodes are in the incorrect order.

Code Reproduction URL

https://stackblitz.com/edit/stencil-start-ydmeww

Additional Information

when re-writing client-hydrate I didn't take into account some new resolving heuristics that were more-recently added to vdom-render.
*edit ... this pattern was completely broken in previous Stencil versions so not a regression

Fix in-bound

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants