-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup CLI flags and options for InfluxDB 3 #25646
Comments
We could also use #[clap(hide = true)] but then, I am not sure if there is a way for users to see those blocks at all, unless they refer to some external provided documentation. This would help maintain compatibility in the short term, e.g., with the perf team's test harness, which is using several of the clap blocks from IOx like object store, tracing, and logging (perhaps others). |
The object store, tracing and log blocks should be relevant to Monolith, shouldn't they? Meaning we don't want to hide them. |
I think all the blocks we are using are relevant. But there is a lot of IOx verbiage in them and the associated environment variables all use the |
We should do the cleanup in advance of the alpha. |
I think we can just copy the relevant parts that we need from |
Use case:
A better user experience tailored towards InfluxDB 3 OSS version
Proposal:
Roll our own
clap_blocks
crate for OSSCurrent behaviour:
Currently we have
clap
options set by reusingclap_blocks
from IOx and it reflects so in the comments which can be confusing and it includes many options we do not need for OSS that can make it hard for users to discover what options are available to them.Desired behaviour:
clap_block
dependency from coreAlternatives considered:
We can also just do them inline in
influxdb3
or not at all. With internal feedback however this is considered confusing and verbose and not doing it all is not as viable an option as other users are likely to experience the same confusion.The text was updated successfully, but these errors were encountered: