Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization Auto Adjoint doesn't work with scaling of the system #29570

Open
maxnezdyur opened this issue Dec 18, 2024 · 0 comments · May be fixed by #29571
Open

Optimization Auto Adjoint doesn't work with scaling of the system #29570

maxnezdyur opened this issue Dec 18, 2024 · 0 comments · May be fixed by #29571
Labels
P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@maxnezdyur
Copy link
Contributor

Bug Description

When using automatic_scaling or "manual" scaling of variables, the adjoint system doesn't scale properly. While the gradients for the optimization will point in the correct direction they can become scaled such that gradient tolerances become useless.

Steps to Reproduce

Turn on automatic scaling and observe convergence criteria.

Impact

This can make the working with coupled physics hard when scaling is especially useful.

[Optional] Diagnostics

No response
@maxnezdyur maxnezdyur added P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations. labels Dec 18, 2024
maxnezdyur added a commit to maxnezdyur/moose that referenced this issue Dec 18, 2024
@maxnezdyur
add consistent scaling for optimization problems idaholab#29570
29eda20
maxnezdyur added a commit to maxnezdyur/moose that referenced this issue Dec 18, 2024
@maxnezdyur
add consistent scaling for optimization problems idaholab#29570
c18380c
@maxnezdyur maxnezdyur linked a pull request Dec 18, 2024 that will close this issue
Open
maxnezdyur added a commit to maxnezdyur/moose that referenced this issue Dec 18, 2024
@maxnezdyur
add consistent scaling for optimization problems idaholab#29570
4d6fc7d
maxnezdyur added a commit to maxnezdyur/moose that referenced this issue Dec 18, 2024
@maxnezdyur
add consistent scaling for optimization problems idaholab#29570
75dd85b
maxnezdyur added a commit to maxnezdyur/moose that referenced this issue Dec 19, 2024
@maxnezdyur
add consistent scaling for optimization problems idaholab#29570
6efdd98
maxnezdyur added a commit to maxnezdyur/moose that referenced this issue Dec 19, 2024
@maxnezdyur
add consistent scaling for optimization problems idaholab#29570
d3c6cd3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add consistent scaling for optimization problems maxnezdyur/moose
1 participant
@maxnezdyur